http://git.samba.org/?p=tprouty/samba.git; a=shortlog; h=create_file_refactor

[Volker Lendecke]

On Sun, Nov 23, 2008 at 11:24:56PM -0800, Tim Prouty wrote:
> Jeremy/Volker (and any others),
> 
> The series of patches in the subject line adds support for a new  
> SMB_VFS_CREATE_FILE call in the vfs layer.  I changed all callers of  
> create_file, create_file_unixpath, open_file_ntcreate, open_directory,  
> and open_file to call through the vfs layer.
> 
> I added the call to vfs_full_audit.c and made a note of the change in  
> vfs.h, but didn't increase the version number since there has already  
> been a change since v3-3.
> 
> "make test"  passes with my changes, but these patches touch some very  
> central code paths, so I would love any feedback or suggestions.

In general that looks very good, although I am a bit worried
about the implications of changing the direct callers of
open_file_ntcreate to create_file. open_file_ntcreate
assumes quite a bit of preprocessing like a unix path etc,
create_file does this again. It does survive make test for
me as well, but I'm not sure those code paths are really
covered by make test. For example, copy_internals, which
test does cover that?

Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20081129/9b5fee86/attachment.bin