[PATCH] Add --with-ext-lib-XXX support to SMB_EXT_LIB_FROM_PKGCONFIG

[Jelmer Vernooij]

Hi Sam,

I don't think our comments are necessarily conflicting. I agree with
metze's comment about using this everywhere we are using
SMB_EXT_LIB_FROM_PKGCONFIG(), but I think it should be split up rather
than one big lump of code.

Metze doesn't mention anything about --enable as far as I can see. 

Cheers,

Jelmer

On Wed, 2008-11-26 at 17:15 +0000, Sam Liddicott wrote:
> Good tips, but metze told me to do exactly the opposite to what you just suggest, in each case.
>  :-)
> 
> Sam
> 
> -----Original Message-----
> From: Jelmer Vernooij <jelmer at samba.org>
> Sent: 26 November 2008 16:54
> To: Sam Liddicott <sam at liddicott.com>
> Cc: samba-technical <samba-technical at lists.samba.org>; Stefan (metze) Metzmacher <metze at samba.org>
> Subject: Re: [PATCH] Add --with-ext-lib-XXX support to SMB_EXT_LIB_FROM_PKGCONFIG
> 
> Hi Sam,
> 
> On Wed, 2008-11-26 at 15:35 +0000, Sam Liddicott wrote:
> > metze? Did I meet your expectations?
> > 
> > This one avoids checking for the literal "yes" so that
> >  --with-ext-lib-LIBLDB=/path/to
> > could be more easily supported although I don't add that support here
> Any chance you could use something like --enable-external-libldb ?
> autoconf recommends --enable-* for yes/no/auto type questions (and
> --with- for locations). This is also consistent with
> --enable-external-heimdal that we already have.
> 
> > Where XXX is also the first argument to SMB_EXT_LIB_FROM_PKGCONFIG
> > e.g.
> > 
> > as
> >   SMB_EXT_LIB_FROM_PKGCONFIG(LIBLDB, ....
> > exists in configure.ac it is now also possible to force selection
> > of the built-in LIBLDB, or the external LDB, or to prefer the
> > external LIBLDB if it is present by passing to ./configure
> 
> Please use a separate macro for this that uses the current
> SMB_EXT_LIB_FROM_PKG_CONFIG, otherwise the SMB_EXT_LIB_FROM_PKGCONFIG()
> becomes too hard to understand.
> 
> Cheers,
> 
> Jelmer
-- 
Jelmer Vernooij <jelmer at samba.org> - http://samba.org/~jelmer/
Jabber: jelmer at jabber.fsfe.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 315 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20081126/8c0f6690/attachment.bin