[PATCH] Add --with-ext-lib-XXX support to
SMB_EXT_LIB_FROM_PKGCONFIG
Jelmer Vernooij
jelmer at samba.org
Wed Nov 26 16:54:21 GMT 2008
Hi Sam,
On Wed, 2008-11-26 at 15:35 +0000, Sam Liddicott wrote:
> metze? Did I meet your expectations?
>
> This one avoids checking for the literal "yes" so that
> --with-ext-lib-LIBLDB=/path/to
> could be more easily supported although I don't add that support here
Any chance you could use something like --enable-external-libldb ?
autoconf recommends --enable-* for yes/no/auto type questions (and
--with- for locations). This is also consistent with
--enable-external-heimdal that we already have.
> Where XXX is also the first argument to SMB_EXT_LIB_FROM_PKGCONFIG
> e.g.
>
> as
> SMB_EXT_LIB_FROM_PKGCONFIG(LIBLDB, ....
> exists in configure.ac it is now also possible to force selection
> of the built-in LIBLDB, or the external LDB, or to prefer the
> external LIBLDB if it is present by passing to ./configure
Please use a separate macro for this that uses the current
SMB_EXT_LIB_FROM_PKG_CONFIG, otherwise the SMB_EXT_LIB_FROM_PKGCONFIG()
becomes too hard to understand.
Cheers,
Jelmer
--
Jelmer Vernooij <jelmer at samba.org> - http://samba.org/~jelmer/
Jabber: jelmer at jabber.fsfe.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 315 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20081126/4f685ae7/attachment.bin
More information about the samba-technical
mailing list