[PATCH] Add --with-ext-lib-XXX support to SMB_EXT_LIB_FROM_PKGCONFIG

Sam Liddicott sam at liddicott.com
Fri Nov 21 13:39:10 GMT 2008


Metze: that patch is wrong near the top - it should compare to xno, not no.

New one to follow after more testing.

Sam

* Sam Liddicott wrote, On 21/11/08 12:27:
> Where XXX is also the first argument to SMB_EXT_LIB_FROM_PKGCONFIG
> e.g.
>
> as
>   SMB_EXT_LIB_FROM_PKGCONFIG(LIBLDB, ....
> exists in configure.ac it is now also possible to force selection
> of the built-in LIBLDB, or the external LDB, or to prefer the
> external LIBLDB if it is present by passing to ./configure
>
> --with-ext-lib-LIBLDB
> or
> --without-ext-lib-LIBLDB
> or
> --with-ext-lib-LIBLDB=auto
>
> The behavour defaults to "auto" but can be specified in a new
> 5th parameter to SMB_EXT_LIB_FROM_PKGCONFIG.
>
> Signed-off-by: Sam Liddicott <sam at liddicott.com>
> ---
>  source4/build/m4/public.m4 |  116
> +++++++++++++++++++++++++------------------
>  1 files changed, 67 insertions(+), 49 deletions(-)
>
> Metze, I couldn't follow the logic you laid out because the macro's used
> in $3 and $4 start complaining about being invoked multiple times:
>
> configure.ac:95: error: `lib/ldb/ldb.pc' is already registered with
> AC_CONFIG_FILES.
> autoconf/status.m4:848: AC_CONFIG_FILES is expanded from...
> build/m4/public.m4:155: SMB_EXT_LIB_FROM_PKGCONFIG is expanded from...
>
> AS_CASE didn't work, either.
>
> Sam
>
>   



More information about the samba-technical mailing list