[SCM] Samba Shared Repository - branch master updated -ce44a2032362c6160931663af67e2e2e663b0c63

Steven Danneman steven.danneman at isilon.com
Wed Nov 19 18:43:39 GMT 2008


> On Tue, Nov 18, 2008 at 07:11:50PM -0600, Steven Danneman wrote:
> > - Log
> > -----------------------------------------------------------------
> > commit ce44a2032362c6160931663af67e2e2e663b0c63
> > Author: Steven Danneman <steven.danneman at isilon.com>
> > Date:   Mon Oct 27 23:36:36 2008 -0700
> >
> >     Clean-up various trailing space and >80 column lines.
> 
> Reformatting is deprecated for a while now :-)
> 
> The only thing I regularly do is change the nonempty blank lines. The
> main point against reformatting is the fact that "git blame" is broken
> for no real reason, blank lines are not really hurt here.

Sure, I understand the desire for git-blame to work easily.  At the same
time I felt there was a push to clean up existing code as you work on it
to match the style guidelines (master/README.Coding).

"git-blame -w" seems able to detect whitespace-only changes made
anywhere on a single line, but unable to detect newlines when breaking
apart statements longer than 80 chars.

I'll avoid making changes that "git-blame -w" can't detect.

-Steven


More information about the samba-technical mailing list