[SCM] Samba Shared Repository - branch master updated - 3d0a3c1078d936a52ce82720ddc09b4037653655

[simo]

On Sun, 2008-11-16 at 18:12 -0600, Andrew Bartlett wrote:
> The branch, master has been updated
>        via  3d0a3c1078d936a52ce82720ddc09b4037653655 (commit)
>        via  16a3a2da78b1f2d5a1077e382a26466944f6c59e (commit)
>        via  cf5c919c744c714b9be849e4d6424f7df92b328d (commit)
>        via  5b796adb125174084cfc2a6f04cfdac5e9324ef8 (commit)
>        via  00b63434063a128662d4ce83ce382fc2e6102d22 (commit)
>        via  8e1934a3845944ba7d79848368976e82d182e8d1 (commit)
>        via  109719de030cb2432bea991077b12b4cf937c108 (commit)
>        via  9abd45979ee0415c16775f6dfd17a6e421091d5c (commit)
>       from  1d9c88b3885728aba3d7fef85d80501125011f1c (commit)
> 
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> 
> 
> - Log -----------------------------------------------------------------
> commit 3d0a3c1078d936a52ce82720ddc09b4037653655
> Author: Andrew Bartlett <abartlet at samba.org>
> Date:   Wed Nov 5 12:00:44 2008 +1100
> 
>     Add helpful function for comparison of DATA_BLOB elements
> 
> commit 16a3a2da78b1f2d5a1077e382a26466944f6c59e
> Author: Andrew Bartlett <abartlet at samba.org>
> Date:   Thu Nov 13 14:07:29 2008 +1100
> 
>     Remove timeout event once we are calling the callback.
>     
>     (Even if the callback takes some time, this isn't a ldb_tdb timeout
>     any more)
>     
>     Andrew Bartlett

I think this is wrong Andrew.
The callback is fully part of the call and the timeout should apply.
You may rise the timeout time if you think that normally we should give
more time. But certainly not remove the timeout imo.

> commit cf5c919c744c714b9be849e4d6424f7df92b328d
> Author: Andrew Bartlett <abartlet at samba.org>
> Date:   Thu Nov 13 15:58:12 2008 +1100
> 
>     Improve debug when SASL search fails
> 
> commit 5b796adb125174084cfc2a6f04cfdac5e9324ef8
> Author: Andrew Bartlett <abartlet at samba.org>
> Date:   Fri Nov 14 09:40:02 2008 +1100
> 
>     Print unconvertable ldb element values as base64.
>     
>     If an LDB element cannot be converted into a printable form, we should
>     still print it, just with safety applied.
>     
>     Andrew Bartlett
> 
> commit 00b63434063a128662d4ce83ce382fc2e6102d22
> Author: Andrew Bartlett <abartlet at samba.org>
> Date:   Fri Nov 14 13:26:02 2008 +1100
> 
>     The samba3sam test does not really need the extended_dn module
>     
>     (This module has been split up into extended_dn_in, extended_dn_out
>     and extended_dn_store).
>     
>     Andrew Bartlett
> 
> commit 8e1934a3845944ba7d79848368976e82d182e8d1
> Author: Andrew Bartlett <abartlet at samba.org>
> Date:   Fri Nov 14 13:24:54 2008 +1100
> 
>     Use new GUID_from_data_blob
>     
>     This avoid the problem that GUID_from_string now strictly requires no
>     trailing data after the string-form GUID.
>     
>     Andrew Bartlett
> 
> commit 109719de030cb2432bea991077b12b4cf937c108
> Author: Andrew Bartlett <abartlet at samba.org>
> Date:   Fri Nov 14 16:34:59 2008 +1100
> 
>     Remove restrictions on number of DN components in LDAP server
>     
>     There is no reason for these restrictions to be in the LDAP server -
>     they belong in the LDB layer.  When accepting 'extended' or
>     'alternate' DNs we can't tell anyway.

No, they certainly do not belong in LDB, as LDB does not have the same
restrictions as the LDAP server. I would like you to put them back.
    
>     Andrew Bartlett
> 
> commit 9abd45979ee0415c16775f6dfd17a6e421091d5c
> Author: Andrew Bartlett <abartlet at samba.org>
> Date:   Fri Nov 14 17:16:39 2008 +1100
> 
>     Always validate a DN when constructing from a string in python

This may make the python bindings much slower ... but perhaps that's ok
for the bindings.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Senior Software Engineer at Red Hat Inc. <simo at redhat.com>