idmap_ad.c question

Gerald (Jerry) Carter jerry at samba.org
Wed Nov 12 14:34:31 GMT 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Herb Lewis wrote:
> the functions idmap_ad_sids_to_unixids and idmap_ad_unixids_to_sids
> call ads_pull_string which tallocs the returned char *
> 
> This call is inside a for loop but talloc_free is not called on the
> value. Is this a potential memory leak or am I missing something here.
> I must admit I really don't fully understand the talloc subsystem.

Hey Herb,

I don't see ads_pull_striung except in the alias mapping
and nss_get_info() code.  I see a local memctx in the two
functions you refer to but that is freed at the exit from
the function.




cheers, jerry
- --
=====================================================================
Samba                                    ------- http://www.samba.org
Likewise Software          ---------  http://www.likewisesoftware.com
"What man is a man who does not make the world better?"      --Balian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFJGul3IR7qMdg1EfYRAlUqAJ4jp5n2Hn/10OKDP0MSs7n3QKPmAACg0gHb
KWiTqHgcuxW3CZM1OCODdHk=
=hVqt
-----END PGP SIGNATURE-----


More information about the samba-technical mailing list