str_list_make in master

[Jelmer Vernooij]

Am Donnerstag, den 06.11.2008, 18:50 -0800 schrieb Jeremy Allison:
> On Thu, Nov 06, 2008 at 11:10:20AM -0800, Dan Sledz wrote:
> > It appears the behavior of str_list_make changed between samba 3.2 and
> > master.
> > 
> > In samba 3.2 passing NULL or an empty string returned NULL.
> > 
> > In master, it now returns a list of length 1 with the first string set
> > to NULL (an empty list)
> > 
> >  
> > 
> > In our smb.conf,  we use "valid users = " to imply that everyone has
> > access to a share.  The new behavior now causes user_ok_token() to deny
> > everyone.  As a workaround, I've stopped setting "valid users", but it's
> > concerning that I'm unable to express the default value in smb.conf.
> > 
> >  
> > 
> > Should the callers adjust or should str_list_make change?
> Ok, here's the fix I'll commit. Added a wrapper str_list_make_v3
> to restore the old behavior.
Thanks, Jeremy! I tried to be careful while merging, but it seems I've
missed this one. There's a testsuite for the new behaviour, so at least
it shouldn't regress again :-)

Cheers,

Jelmer

-- 
Jelmer Vernooij <jelmer at samba.org> - http://samba.org/~jelmer/
Jabber: jelmer at jabber.fsfe.org