directory_create_or_exist() and umask

Andrew Bartlett abartlet at samba.org
Thu Nov 6 22:40:31 GMT 2008


On Thu, 2008-11-06 at 11:31 +0100, Stefan (metze) Metzmacher wrote:
> Hi Andrew,
> 
> shouldn't directory_create_or_exist() call umask(old_umask) when it
> returns true?

Indeed.  We should also ensure we never call this function in a
multi-threaded program...

Please fix,

Thanks!
-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Red Hat Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20081107/de497e4d/attachment.bin


More information about the samba-technical mailing list