Extending LDB for Extended DNs

[simo]

On Wed, 2008-11-05 at 16:25 +0100, Jelmer Vernooij wrote:
> Am Mittwoch, den 05.11.2008, 09:27 -0500 schrieb simo:
> > On Wed, 2008-11-05 at 22:33 +1100, Andrew Bartlett wrote:
> > > On Tue, 2008-10-28 at 08:13 +0100, Stefan (metze) Metzmacher wrote:
> > > > Andrew Bartlett schrieb:
> > > Great.  I've been working on this hard for the past week or so.  See
> > > http://gitweb.samba.org/?p=abartlet/samba.git/.git;a=shortlog for the
> > > current work in progress.
> > > 
> > > I'm currently working on the comprehensive testsuite for DN behaviours,
> > > particularly with the extended DNs.
> > > 
> > > I would appreciate any comments or feedback,
> > Andrew it would make it much easier to evaluate if you could rebase and
> > re-group your patched code on top of the current branch and maybe label
> > the commits so that they are clearly recognizable and separated in
> > relevant units. more or less like I did for the LDB Async work.
> > 
> > git rebase is a great tool for that :-)
> FWIW, you can also get the diff for just Andrews branch by running
> something like:
> 
> $ git diff origin/master...abartlet/master
> 
> The three dots will determine the common base between origin/master and
> abartlet/master and show the diff between that and abartlet/master.

I know, but it is much easier if the author filters out unimportant
changes and put in evidence core patches than having everybody else dig
out diffs.

It will make also for much clearer commits later on upstream.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Senior Software Engineer at Red Hat Inc. <simo at redhat.com>