[SCM] Samba Shared Repository - branch master updated - 17218df56714237d319673c17ddd2c75795d6285

[Michael Adam]

Jeremy Allison wrote:
> On Sun, Nov 02, 2008 at 03:28:02PM -0600, Michael Adam wrote:
> > The branch, master has been updated
> >        via  17218df56714237d319673c17ddd2c75795d6285 (commit)
> >       from  f3e638bc9fad7d3a54a9b41de8857c126c656f5c (commit)
> > 
> > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> > 
> > 
> > - Log -----------------------------------------------------------------
> > commit 17218df56714237d319673c17ddd2c75795d6285
> > Author: Michael Adam <obnox at samba.org>
> > Date:   Thu Oct 30 16:38:07 2008 +0100
> > 
> >     [s3]winbindd: speed up fill_grent_mem (i.e. winbindd_getgrent) a lot.
> >     
> >     With large groups, getgrent ran into timeouts because after each
> >     single user that was added to the expanded group list, the list
> >     was sorted and made unique.
> >     
> >     Now the list is sorted just once after all members have been added.
> 
> Great work Michael, thanks a *lot* !

I was at that customer's site and wondering why a special group did
not get resolved (getgrgid). After the debugging and tuning, it
turned out that the group had > 250,000 members and winbindd had just
spent for ever (until time out) in qsort.

:-)

Cheers - Michael

-- 
Michael Adam <ma at sernet.de>
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.SerNet.DE, mailto: Info @ SerNet.DE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 206 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20081103/3fa79901/attachment.bin