Bug 5453

Stefan (metze) Metzmacher metze at samba.org
Fri May 23 05:27:13 GMT 2008

Guenther Deschner schrieb:
> Guenther Deschner wrote:
>> Hi Volker,
>> Volker Lendecke wrote:
>>> Hi, Günther!
>>> Just for your information: I'm preparing a patch to
>>> deactivate all code that calls dsgetdcname.
>> I think this will not improve the current situation and just create
>> another poorly tested codepath (as we would need to have replacement
>> calls then for at least joining AD, etc.).
>> So, my proposal is:
>> align the dsgetcdname() codepath with the stuff in 3-3-test.
>> This would be the cherry-pick list for 3-2:
>> http://www.samba.org/~gd/liste-3-2-test
>> and for 3-2-stable:
>> http://www.samba.org/~gd/liste-3-2-stable
>> This are a lot of patches, I know, pre3 just shipped with a 30%
>> finished  feature (and with that crash bug). Now moving backwards is
>> as good/bad as moving forward, IMHO.
>> For reference, here are the code paths which touch this:
>> * dsgetdcname call in winbindd (used by wbinfo/libwbinfo, and krb5
>> locator)
>> * rpc server wkssvc remote join and unjoin calls
>> * "net ads join"/libnetjoin
>> * libnetapi callers (just example code)
>> Sounds ok ?
> Alternatively, if we decide not to trust it, we could just revert
> 76aca0f26f497883b257cf40a9274ff8301e42ad and thereby leave dsgetdcname
> crippled and remove netbios name support entirely.

I'd like to go forward...


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
Url : http://lists.samba.org/archive/samba-technical/attachments/20080523/4d3d6c16/signature.bin

More information about the samba-technical mailing list