Improving performance of winbindd_list_groups

Gerald (Jerry) Carter jerry at
Fri May 9 20:26:14 GMT 2008

Hash: SHA1

Volker Lendecke wrote:
> On Thu, Apr 24, 2008 at 05:51:13PM -0700, Steven Danneman wrote:
>> That's a good suggestion for even better performance.  Attached is an
>> updated patch using talloc_asprintf_append_buffer().  I'm wasn't
>> positive from the API description that the returned string will be NULL
>> terminated, but in all my tests it seems to be.  Is this a correct
>> assumption?
> Yep. Down below it calls vsnprintf somewhere, that
> terminates. I'd check in your patch, but I'd like Jerry to
> take a look and comment first.

Looks good to me (reading through)  Have not tested if but
in theory I can follow the logic and it seems sound.   I'm in
the ATL airport right now and don't really want to burn
battery booting VMs for testing.  But I can deal with this
on Monday if you like.  Or if Volker or someone else has
already tested it, I'm happy if they wanna check it into
the v3-3-test branch.

cheers, jerry
- --
Samba                                    -------
Likewise Software          ---------
"What man is a man who does not make the world better?"      --Balian
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla -


More information about the samba-technical mailing list