lib/replace/replace.c initgroups() max_gr

Michael Adam ma at sernet.de
Wed Mar 26 09:26:34 GMT 2008


Hi,

this looks very reasonable to me. We also make sure in
lib/replace/system/passwd.h, that NGROUPS_MAX is defined.

If you would like to repost the patch as a git commit exported
with "git format-patch", then you would get the creds for this
(i.e. you would be blamed... ;-) But I can also simply put this in.

Cheers, Michael

yaberger at ca.ibm.com wrote:
> Hi
> 
> I was wondering why max_gr  was set to 32 instead of using the NGROUPS_MAX 
> variable, which is usually in limits.h or set to 32 if NGROUPS_MAX isn't 
> defined
> 
> ie on AIX:
> 
> /usr/include/sys/limits.h
> 
> #define NGROUPS_MAX     128             /* max number of supplementary 
> group IDs
>                                            per process, >= 0 */
> 
> 
> the patch if you decide to use the NGROUPS_MAX variable instead of a 
> static 32 value
> 
> 
> 
> 
> 
> Regards,
> 
> 
> Yannick Bergeron
> yaberger at ca.ibm.com

-- 
Michael Adam <ma at sernet.de>  <obnox at samba.org>
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.SerNet.DE, mailto: Info @ SerNet.DE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 206 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20080326/a81a5029/attachment.bin


More information about the samba-technical mailing list