[PATCH] Cleanup for Coverity issues

Volker Lendecke Volker.Lendecke at SerNet.DE
Sat Mar 15 09:51:14 GMT 2008

On Fri, Mar 14, 2008 at 03:33:57PM -0700, Marc VanHeyningen wrote:
> This patch mostly concerns a number of Coverity warnings about unchecked
> return values.  I've been meaning to submit this for a while, sorry
> about the delay.

I'd say that this can go straight in, but I've got some
really minor comments that make it even better I think:

If the push_ctx() in become_root() fails, just smb_panic().

The string_to_sid failures from constant strings could
better be converted to a

sid_copy(&sid_Builtin, &global_sid_Builtin)

etc where global_sid_Builtin and friends are defined in

Do you want to re-submit the patch with those changes or do
you want me to make them?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20080315/67b5a7c2/attachment.bin

More information about the samba-technical mailing list