[SCM] Samba Shared Repository - branch v3-2-test updated - release-3-2-0pre2-124-g6f65390

Derrell Lipman derrell.lipman at unwireduniverse.com
Thu Mar 6 14:24:50 GMT 2008

On Thu, Mar 6, 2008 at 9:16 AM, Volker Lendecke
<Volker.Lendecke at sernet.de> wrote:
> Hi, Derrell!
>  On Thu, Mar 06, 2008 at 08:01:35AM -0600, Derrell Lipman wrote:
>  > The branch, v3-2-test has been updated
>  >        via  6f65390cec218a6aac4370ee381f30439617dcec (commit)
>  >       from  3a0f781352f364ce625a35ffd78257b27d984c47 (commit)
>  >
>  > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test
>  >
>  >
>  > - Log -----------------------------------------------------------------
>  > commit 6f65390cec218a6aac4370ee381f30439617dcec
>  > Author: Derrell Lipman <derrell.lipman at unwireduniverse.com>
>  > Date:   Thu Mar 6 09:00:37 2008 -0500
>  >
>  >     Check for NULL pointers before dereferencing them.
>  Quick question -- was this in response to the patch I sent
>  to you in "git format-patch" format? If yes, it would have
>  been nice if you had applied it with git am, this would have
>  kept the original checkin message around. An effect would
>  have been that I am listed as the patch author, but much
>  more importantly the Coverity IDs would have been kept
>  intact.

Hi Volker,

This was in response to the patch you sent.  Your patch, though, was
included in-line, not attached.  Since I read my email using gmail
(web mail), an inline patch must be copy/pasted rather than
downloaded.  My experience has been that this copy/paste process
introduces all sorts of white-space differences that cause patches to
fail, so with this very simple patch, it was easier to just make the

Sorry I didn't mention you in the commit message.  I certainly should
have, and I didn't know that tracking coverity IDs was important.



More information about the samba-technical mailing list