Reviewing b58e4f6b3d7329....

[Gerald (Jerry) Carter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Volker Lendecke wrote:
> On Mon, Jun 30, 2008 at 11:30:33AM -0500, Gerald (Jerry) Carter wrote:
>
>> Was there a functional bug here?  The report is academic IMO.  So
>> we've traded have of the cache benefit for ensuring that
>> Sid2name returns proper case.  but smbd looks at names in case
>> insenstive fashion and the NSS calls are normalized to lower
>> case.
>>
>>> Please inform me as soon as possible if this patch should be removed
>>> before we ship the final release.
>> Unless there is a functional bug here, I would like to revert it.
>
> Well, we should at least return consistent upper/lower case
> IMO. Not something that the user can influence.

ok.  I give up.  Whatever you want to do.  I still think dropping
the cache entry is the wrong thing to do but I'll do a patch later.
Just help me understand why throwing away valid cache information
was necessary.

I think my confusion is that this is an internal caching
mechanism to me.  What was the customer complaining about
and what in their environment specially *broke*. or were they
just confused by the output from wbinfo?

So why didn't we do a proper fix as you propose normalize the case?
Seems I'm not seeing the entire picture here.




cheers, jerry
- --
=====================================================================
Samba                                    ------- http://www.samba.org
Likewise Software          ---------  http://www.likewisesoftware.com
"What man is a man who does not make the world better?"      --Balian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIaUtuIR7qMdg1EfYRAmt+AKDALsUVEwRknxF1IIdN+e3yoJfkbACfQu/j
Ipt0Ih+Evf+pBLuYM9IoUXA=
=Spi0
-----END PGP SIGNATURE-----