Reviewing b58e4f6b3d7329....

[Karolin Seeger]

Jerry, Volker,

On Mon, Jun 30, 2008 at 09:08:07PM +0200, Volker Lendecke wrote:
> On Mon, Jun 30, 2008 at 11:30:33AM -0500, Gerald (Jerry) Carter wrote:
> 
> > Was there a functional bug here?  The report is academic IMO.  So
> > we've traded have of the cache benefit for ensuring that
> > Sid2name returns proper case.  but smbd looks at names in case
> > insenstive fashion and the NSS calls are normalized to lower
> > case.
> > 
> > > Please inform me as soon as possible if this patch should be removed
> > > before we ship the final release.
> > 
> > Unless there is a functional bug here, I would like to revert it.

I noticed a few hours ago that this patch is not in v3-2-stable. Sorry for
the confusion. So time does not matter now...

> Well, we should at least return consistent upper/lower case
> IMO. Not something that the user can influence.

+1

Btw: It was a customer who was complaining about inconsistent results.
So it's not too academic... ;-)

Karolin

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.SerNet.DE, mailto: Info @ SerNet.DE