Bug in smbldap-tools

[Jeremy Allison]

Hi Jerome,

	I have found a bug in smbldap-tools, reported to me
in Samba bugid #5551 :

https://bugzilla.samba.org/show_bug.cgi?id=5551

You are creating the alias groups with the wrong
group type. Currently you're using type 5 (in
Samba this is SID_NAME_WKN_GRP) and it should
be type 4 (SID_NAME_ALIAS).

I know this as we made the same mistake in Samba
a few releases ago.

I'm attaching a patch to smbldap-tools-0.9.5 that
will fix this going forward.

Thanks a lot !

Jeremy Allison,
Samba Team.
-------------- next part --------------
--- smbldap-populate.orig	2008-06-25 11:24:09.000000000 -0700
+++ smbldap-populate	2008-06-25 11:31:51.000000000 -0700
@@ -337,7 +337,7 @@
 cn: Administrators
 description: Netbios Domain Members can fully administer the computer/sambaDomainName
 sambaSID: S-1-5-32-544
-sambaGroupType: 5
+sambaGroupType: 4
 displayName: Administrators
 
 #dn: cn=Users,$config{groupsdn}
@@ -348,7 +348,7 @@
 #cn: Users
 #description: Netbios Domain Ordinary users
 #sambaSID: S-1-5-32-545
-#sambaGroupType: 5
+#sambaGroupType: 4
 #displayName: users
 
 #dn: cn=Guests,$config{groupsdn}
@@ -360,7 +360,7 @@
 #memberUid: $guestName
 #description: Netbios Domain Users granted guest access to the computer/sambaDomainName
 #sambaSID: S-1-5-32-546
-#sambaGroupType: 5
+#sambaGroupType: 4
 #displayName: Guests
 
 #dn: cn=Power Users,$config{groupsdn}
@@ -371,7 +371,7 @@
 #cn: Power Users
 #description: Netbios Domain Members can share directories and printers
 #sambaSID: S-1-5-32-547
-#sambaGroupType: 5
+#sambaGroupType: 4
 #displayName: Power Users
 
 dn: cn=Account Operators,$config{groupsdn}
@@ -382,7 +382,7 @@
 cn: Account Operators
 description: Netbios Domain Users to manipulate users accounts
 sambaSID: S-1-5-32-548
-sambaGroupType: 5
+sambaGroupType: 4
 displayName: Account Operators
 
 #dn: cn=System Operators,$config{groupsdn}
@@ -393,7 +393,7 @@
 #cn: System Operators
 #description: Netbios Domain System Operators
 #sambaSID: S-1-5-32-549
-#sambaGroupType: 5
+#sambaGroupType: 4
 #displayName: System Operators
 
 dn: cn=Print Operators,$config{groupsdn}
@@ -404,7 +404,7 @@
 cn: Print Operators
 description: Netbios Domain Print Operators
 sambaSID: S-1-5-32-550
-sambaGroupType: 5
+sambaGroupType: 4
 displayName: Print Operators
 
 dn: cn=Backup Operators,$config{groupsdn}
@@ -415,7 +415,7 @@
 cn: Backup Operators
 description: Netbios Domain Members can bypass file security to back up files
 sambaSID: S-1-5-32-551
-sambaGroupType: 5
+sambaGroupType: 4
 displayName: Backup Operators
 
 dn: cn=Replicators,$config{groupsdn}
@@ -426,7 +426,7 @@
 cn: Replicators
 description: Netbios Domain Supports file replication in a sambaDomainName
 sambaSID: S-1-5-32-552
-sambaGroupType: 5
+sambaGroupType: 4
 displayName: Replicators
 
 ";