[SCM] Samba Shared Repository - branch v4-0-test updated - release-4-0-0alpha4-105-g87385e4

simo idra at samba.org
Mon Jun 23 03:00:17 GMT 2008

On Thu, 2008-06-19 at 07:52 -0500, Stefan Metzmacher wrote:
> @@ -34,6 +34,7 @@
>  #include "replace.h"
>  #include "events.h"
>  #include "events_internal.h"
> +#include "events_util.h"
>  #include <sys/epoll.h>
>  #include <libaio.h>

I was going to say that this is unnecessary because events_util.h was
included in events_internal.h but then I saw Jelmer's patch that removed
events_util.h from events_internal.h

I think your patch is wrong, events_util.h defines only internally used
helper functions, so the fix should have been to not install
events_util.h imo, not to untangle it from events_internal.h, can you
fix that, or should I revert and fix it myself ?


Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Senior Software Engineer at Red Hat Inc. <ssorce at redhat.com>

More information about the samba-technical mailing list