3.2 Makefile.in question

[Gerald (Jerry) Carter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Michael Adam wrote:
> Gerald (Jerry) Carter wrote:
>> Herb Lewis wrote:
>>> We have the following in the 3.2 Makefile.in (only some lines
>>> shown). Why is the definition of LIBWBCLIENT different to the
>>> others? Looking in configure it probably resolves to being the
>>> same but why not be consistent? Was there a reason for this?
>>>
>>> LIBTALLOC_STATIC_TARGET=@LIBTALLOC_STATIC_TARGET@
>>> LIBTALLOC=$(LIBTALLOC_STATIC_TARGET) @LIBTALLOC_SHARED@
>>>
>>> LIBTDB_STATIC_TARGET=@LIBTDB_STATIC_TARGET@
>>> LIBTDB=$(LIBTDB_STATIC_TARGET) @LIBTDB_SHARED@
>>>
>>> LIBWBCLIENT_STATIC_TARGET=@LIBWBCLIENT_STATIC_TARGET@
>>> LIBWBCLIENT=@LIBWBCLIENT_STATIC@ @LIBWBCLIENT_SHARED@
>>>
>>> LIBNETAPI_STATIC_TARGET=@LIBNETAPI_STATIC_TARGET@
>>> LIBNETAPI=$(LIBNETAPI_STATIC_TARGET) @LIBNETAPI_SHARED@
>> Herb,
>>
>> I'm assuming we always build static version of talloc, tdb,
>> and netapi.  But originally there was no static version of
>> libwbclient and this was managed by a configure option.
>> The reason we don't always build libwbclient.a is that the whole
>> point of libwbclient to to decouple the compile time dependency
>> between smbd and winbindd.
> 
> Right, talloc, tdb and netapi are always built statically,
> and they are configured by the same macro SMB_LIBRARY(...)
> in configure.in.
> 
> For libwbclient on the other hand, Jerry wanted to only have
> a shared library, so that there is no temptation to link it
> in statically. Only with --enable-developer the static lib
> will be built. (Jerry - correct me, if I am getting anything
> wrong here.) Therefore, there needs to be a separation between
> the target to define the build and the dependency that
> triggers the build. Hence the difference.

Nope.  Sounds like a spot on explanation to me.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIWtHRIR7qMdg1EfYRAlR/AKCnlAv/xy6Kpnx6cciqWuevZhpoxQCgjHxR
r++QXozWfvkklBZZzQz44Jk=
=Qyxy
-----END PGP SIGNATURE-----