[SCM] Samba Shared Repository - branch v4-0-test updated - release-4-0-0alpha4-70-g168bb84

[Jelmer Vernooij]

Am Samstag, den 14.06.2008, 22:08 +1000 schrieb Andrew Bartlett:
> On Sat, 2008-06-14 at 05:16 -0500, Jelmer Vernooij wrote:
> > The branch, v4-0-test has been updated
> >        via  168bb8473c0cfeb388f9955059f92410b8ba5d06 (commit)
> >        via  280c411613b21acc1e65e5657b209d266dbad8d3 (commit)
> >       from  0e8f946ed02a6d2d9469f9ccab5f3342b2b80725 (commit)
> > 
> > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v4-0-test
> > 
> 
> > commit 280c411613b21acc1e65e5657b209d266dbad8d3
> > Author: Jelmer Vernooij <jelmer at samba.org>
> > Date:   Sat Jun 14 12:14:27 2008 +0200
> > 
> >     Fix prototype for pthread process model.
> > 
> > -----------------------------------------------------------------------
> > 
> > Summary of changes:
> >  source/smbd/process_model.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > 
> > Changeset truncated at 500 lines:
> > 
> > diff --git a/source/smbd/process_model.c b/source/smbd/process_model.c
> > index e631975..704e6cc 100644
> > --- a/source/smbd/process_model.c
> > +++ b/source/smbd/process_model.c
> > @@ -81,6 +81,7 @@ _PUBLIC_ NTSTATUS register_process_model(const void *_ops)
> >  
> >  _PUBLIC_ NTSTATUS process_model_init(struct loadparm_context *lp_ctx)
> >  {
> > +	extern NTSTATUS process_model_thread_init(void);
> >  	extern NTSTATUS process_model_standard_init(void);
> >  	extern NTSTATUS process_model_prefork_init(void);
> >  	extern NTSTATUS process_model_single_init(void);
> 
> Why can't this be autogenerated?  
> 
> This, like the similar problem in the no-longer-automatic prototypes for
> param options, seems like we are missing an opportunity to just get this
> right once, rather than require manual fixups.
It used to be generated by the build system but that's no longer done
when we migrated the init function handling to gmake.

I guess we could use a prototype header here, though that may be a bit
of overkill for just three prototypes.

Cheers,

Jelmer

-- 
Jelmer Vernooij <jelmer at samba.org> - http://samba.org/~jelmer/
Jabber: jelmer at jabber.fsfe.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 315 bytes
Desc: Dies ist ein digital signierter Nachrichtenteil
Url : http://lists.samba.org/archive/samba-technical/attachments/20080614/9accf68a/attachment.bin