[bug exists with previous patch] Re: Logical hole in pam_sm_chauthtok() and winbindd_dual_pam_chauthtok()?

[Bo Yang]

Hi, All:

     There is still a bug with this.
     WINBIND_CACHED_LOGIN is set in ctrl, but in winbind_chauthtok_request(), WBFLAG_PAM_CACHED_LOGIN is not set in request.flags. Patches for v3-0-test, v3-2-test, v3-3-test in the attachment, Please review them.

Thanks!

>>> Guenther Deschner <gd at samba.org> 06/07/08 1:07 AM >>>
Bo Yang wrote:
> Guenther:
> 
>       Thank you for your explanation of the problem, I understand it.
>       
>       I'll post the modified patch as soon as possible.

Eh, I'm afraid I commited a modified patch already, sorry :)

But thanks for catching this!

Guenther

-- 
Günther Deschner                    GPG-ID: 8EE11688
Red Hat                         gdeschner at redhat.com
Samba Team                              gd at samba.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: cached_login_flag_in_chauthtok-v3-0-test.diff
Type: application/octet-stream
Size: 537 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20080610/65192c1a/cached_login_flag_in_chauthtok-v3-0-test.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cached_login_flag_in_chauthtok-v3-2-test.diff
Type: application/octet-stream
Size: 490 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20080610/65192c1a/cached_login_flag_in_chauthtok-v3-2-test.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cached_login_flag_in_chauthtok-v3-3-test.diff
Type: application/octet-stream
Size: 491 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20080610/65192c1a/cached_login_flag_in_chauthtok-v3-3-test.obj