[SCM] Samba Shared Repository - branch v3-2-test updated - release-3-2-0pre2-2524-g0b2062a

[Jeremy Allison]

On Mon, Jun 09, 2008 at 09:00:23AM +0200, Karolin Seeger wrote:
> Jeremy,
> 
> On Sun, Jun 08, 2008 at 04:20:01PM -0500, Jeremy Allison wrote:
> > The branch, v3-2-test has been updated
> >        via  0b2062a499c69c86cc03130542aaf3e92265b65d (commit)
> >       from  20aa14480e9ae6cea663c67fe9e2d1d3b6fafa7d (commit)
> > 
> > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test
> > 
> > 
> > - Log -----------------------------------------------------------------
> > commit 0b2062a499c69c86cc03130542aaf3e92265b65d
> > Author: Jeremy Allison <jra at samba.org>
> > Date:   Sun Jun 8 14:19:16 2008 -0700
> > 
> >     Bugfix noticed by Herb. On using the again: tag as a
> >     goto target we were not reinitializing the array counts.
> >     
> >     From Herb:
> >     
> >     This is in the file nsswitch/winbindd_cm.c (samba-3.0.30) line 1236
> >     
> >     We have a label again: where we keep trying to find the name of the DC
> >     from the list of IPs returned by get_dcs. If we fail to figure out the
> >     name we do a goto again at the end of the function. The problem is we
> >     don't reset the num_dcs, num_addrs, etc and free the memory in the
> >     various arrays. This seems wrong to me. I have a winbindd core where
> >     I have 9 IPs returned for the DCs but at the time of the crash num_dcs
> >     is 87 and if I look through the array dcs it keeps repeating entries
> >     from the same group of 9
> >     
> >     Jerry, Volker and Guenther please check.
> >     
> >     Jeremy.
> > 
> > -----------------------------------------------------------------------
> 
> to be picked up for 3.2.0rc2?

If Volker passes it. I won't be able to do anything
about this for a week or so.

Jeremy.