[PATCH] Implement negative connection cache in terms of gencache

Marc VanHeyningen marc.vanheyningen at isilon.com
Thu Jun 5 16:09:23 GMT 2008

Volker, thanks for the fixes.  I initially write this on 3.0.23c 
(still in use here at Isilon for a while, alas) and forward-ported 
it, which is where the issues you found came in.

Didn't know git could handle trailing whitespace automagically; handy!
I'll add that to the default config information for everyone here at


-----Original Message-----
From: Volker Lendecke [mailto:Volker.Lendecke at SerNet.DE] 
Sent: Thursday, June 05, 2008 12:45 AM
To: Marc VanHeyningen
Cc: samba-technical at lists.samba.org
Subject: Re: [PATCH] Implement negative connection cache in terms of

On Wed, Jun 04, 2008 at 03:29:07PM -0700, Marc VanHeyningen wrote:
> Per our discussions of last month, here's a proposed change to
> the negative connection cache in terms of the gencache.  This permits
> all process to share a single cache, rather than each of them
> independently having to discover that a server is down.  It amounts to
> complete replacement of libsmb/conncache.c.


Attached find some patches over yours, please comment. In
particular the crash one should have shown up in your

In case you want to apply them, I've applied your patch with

        whitespace = strip

in my ~/.gitconfig which removed some trailing whitespaces.
So my patches might create conflicts, but I'd like to not
add trailing whitespace in new code.


More information about the samba-technical mailing list