Possible null pointer refrence in v3-0-test and v3-2-test

James Peach jorgar at gmail.com
Tue Jun 3 23:58:30 GMT 2008


2008/6/2 Bo Yang <boyang at novell.com>:
> I first encounter the problem when using usershare configuration.
>
> When samba is running, I use net usershare add to add a share and then modify the acl of the share.
>
> Then I access the share from windows XP, null pointers appeared in talloc_strndup() and str_checksum(), which causes
> windows XP lost connection to samba....ie, child smbd crashed.
>
> With the patch applied, windows XP didn't lose connection any more.
>
> I didn't look closely at the process of loading user shares.

I've seen cases where it looks like the usershare loading code can
return a bogusly large snum, which results on lp_foo(snum, ...)
returning NULL. Bad things happen from there.

I haven't reliably reproduced this or tracked it down ....

-- 
James Peach | jorgar at gmail.com


More information about the samba-technical mailing list