Possible null pointer refrence in v3-0-test and v3-2-test

[Bo Yang]

>>> Volker Lendecke <Volker.Lendecke at SerNet.DE> 06/03/08 2:42 PM >>>
On Mon, Jun 02, 2008 at 10:04:35PM -0600, Bo Yang wrote:
> I first encounter the problem when using usershare configuration.
> 
> When samba is running, I use net usershare add to add a
> share and then modify the acl of the share.
> 
> Then I access the share from windows XP, null pointers
> appeared in talloc_strndup() and str_checksum(), which
> causes windows XP lost connection to samba....ie, child
> smbd crashed.
> 
> With the patch applied, windows XP didn't lose connection
> any more.
> 
> I didn't look closely at the process of loading user
> shares.
> 
> But from the user experience, I think the patch is
> necessary.
> 
> Thanks!

Can you run the programs under valgrind and see which
callers call the routines with NULL? We need to fix the
callers.

call stack:

reply_trans2() -----> handle_trans2() ----> call_trans2qfsinfo() ----> volume_label() call talloc_strndup(), str_checksum().

Best 
         regards


Thanks,

Volker