Kerberos Ticket Forwarding Patch/Update (3.2)

[Derrick Schommer]

I'll work on the fixes for those, thanks!

-----Original Message-----
From: Love Hörnquist Åstrand [mailto:lha at kth.se] 
Sent: Saturday, July 26, 2008 14:41
To: Derrick Schommer
Cc: samba-technical at lists.samba.org
Subject: Re: Kerberos Ticket Forwarding Patch/Update (3.2)

The flags field in the 8003 checksum should match the gss-api flags  
given to gss_init_sec_context(), your patch sets it to  
GSSAPI_NO_C_BINDINGS (0), which is wrong, it should at least be  
GSS_C_DELEG_FLAG, see page 4 of rfc1934.

+  uint8_t    deleg[];                    /* Deleg field buffer ( one  
or more bytes of GSS-API data) */

This is not valid c89.

The patch do no byte swaping, so it will only work on LE machines.

Love


25 jul 2008 kl. 20.14 skrev Derrick Schommer:

> Here is the update with C-style comment fixes for 3.2 for the Kerberos
> update and the gss_init() updated to have the C_DELEGAT flag enabled.
>