SMB_MALLOC without check

Andreas Moroder andreas.moroder at gmx.net
Fri Jul 25 10:04:10 GMT 2008


Jeremy Allison schrieb:
> On Thu, Jul 24, 2008 at 09:51:07PM +0200, andreas moroder wrote:
>> Hello,
>>
>> in lib/util_unistr.c at line 110 and 125 memory is allocated with SMB_MALLOC
>> but there is no test if NULL is returned.
> 
> At this point we're so early in the Samba setup that
> we want to crash if this fails. The only other option
> is to call smb_panic.
> 
> Jeremy.
> 
Hello,

IMHO smb_panic sounds better than a crash.

Andreas



More information about the samba-technical mailing list