[PATCH] cifs.upcall: fix compiler warning and some usage typos

Jeff Layton jlayton at redhat.com
Tue Jul 22 11:45:48 GMT 2008

Steve French noticed these warnings when building cifs.upcall:

    Compiling client/cifs.upcall.c
    client/cifs.upcall.c: In function 'usage':
    client/cifs.upcall.c:204: warning: declaration of 'prog' shadows a global declaration
    client/cifs.upcall.c:33: warning: shadowed declaration is here

Change the usage function to not take and arg and have it just use the global
"prog" variable. Fix a typo in the log message generated when an unknown
option is specified. Also getopt() always returns '?' when it sees an unknown
option so there's no point in printing it out.

Signed-off-by: Jeff Layton <jlayton at redhat.com>

 source/client/cifs.upcall.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/source/client/cifs.upcall.c b/source/client/cifs.upcall.c
index 3860f33..825870d 100644
--- a/source/client/cifs.upcall.c
+++ b/source/client/cifs.upcall.c
@@ -201,7 +201,7 @@ int cifs_resolver(const key_serial_t key, const char *key_descr)
-usage(const char *prog)
 	syslog(LOG_WARNING, "Usage: %s [-c] [-v] key_serial", prog);
 	fprintf(stderr, "Usage: %s [-c] [-v] key_serial\n", prog);
@@ -234,7 +234,7 @@ int main(const int argc, char *const argv[])
 			goto out;
-			syslog(LOG_WARNING, "unknow option: %c", c);
+			syslog(LOG_WARNING, "unknown option");
 			goto out;
@@ -242,7 +242,7 @@ int main(const int argc, char *const argv[])
 	/* is there a key? */
 	if (argc <= optind) {
-		usage(prog);
+		usage();
 		goto out;

More information about the samba-technical mailing list