More POSIX like funciton for smbc_write
derrell.lipman at gmail.com
Wed Jul 16 14:37:29 GMT 2008
On Wed, Jul 16, 2008 at 10:17 AM, Volker Lendecke <Volker.Lendecke at sernet.de>
> On Wed, Jul 16, 2008 at 10:05:50AM -0400, Derrell Lipman wrote:
> > On Wed, Jul 16, 2008 at 6:12 AM, Andreas Schneider <anschneider at suse.de>
> > wrote:
> > > attached is a patch to use const for the buffer you pass to the write
> > > function. It is the same for write(2).
> > >
> > I agree that it "should" be const. I wonder, though, if it's appropriate
> > change it now since it is an interface change that will cause warnings
> > all compilations of existing programs. We don't really gain anything by
> > making this change now, but I'm open to changing it in 3.3 if people
> > it's appropriate. If we were to do this change, we should go through all
> > the libsmbclient functions and ensure that all of them use the same
> > signatures as their POSIX companions.
> What is the warning that you expect?
In my pre-caffeine state :-) I was expecting a const / non-const mismatch.
Thanks for the redirection.
More information about the samba-technical