Simplify samba_version_string()

Stefan (metze) Metzmacher metze at samba.org
Wed Jul 16 13:47:28 GMT 2008


Andreas Schneider schrieb:
> Hi,
> 
> attached is a patch which simplifies the samba_version_string() function
> and allows to override it.
> 
> This way it doesn't leak any memory (one valgrind warning less) and
> allows vendors to replace the whole function with their own.

The problem is that plugins will still call may still call
samba_version_string(),

It would be better to have samba_version_string() call the vendor
version. And we should only change it in v3-3 and leave it as is
in v3-2.

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
Url : http://lists.samba.org/archive/samba-technical/attachments/20080716/42a3a3f3/signature.bin


More information about the samba-technical mailing list