[SCM] Samba Shared Repository - branch v4-0-test updated - release-4-0-0alpha5-40-gfafb8ad

[Stefan (metze) Metzmacher]

Michael Adam schrieb:
> The branch, v4-0-test has been updated
>        via  fafb8ad2b81b9a46cf8259bedc1dca5023b06115 (commit)
>       from  76dd521bcf53a245bd1412968e9b921e5c2f10c9 (commit)
> 
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v4-0-test
> 
> 
> - Log -----------------------------------------------------------------
> commit fafb8ad2b81b9a46cf8259bedc1dca5023b06115
> Author: Michael Adam <obnox at samba.org>
> Date:   Tue Jul 8 15:33:36 2008 +0200
> 
>     tdbtool: fix off-by-one error in argument length. (bug #2344)
>     
>     This prevented all commands operating on keys (all non-traverse commands)
>     in tdbtool to fail with a "fetch failed" or "delete failed" message.
>     
>     It seems that it fixes bug #2344 ...
>     
>     Apparently this bug was introduced with 94e53472666ed in 2005.
>     Either nobody is using tdbtool or else tdb_find() has become
>     more strict about the key legth in the meantime. :-)
>     
>     Michael
> 
> -----------------------------------------------------------------------
> 
> Summary of changes:
>  source/lib/tdb/tools/tdbtool.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> 
> Changeset truncated at 500 lines:
> 
> diff --git a/source/lib/tdb/tools/tdbtool.c b/source/lib/tdb/tools/tdbtool.c
> index d104ccd..500e441 100644
> --- a/source/lib/tdb/tools/tdbtool.c
> +++ b/source/lib/tdb/tools/tdbtool.c
> @@ -598,7 +598,7 @@ static char *convert_string(char *instring, size_t *sizep)
>  	}
>  	length++;
>      }
> -    *sizep = length;
> +    *sizep = length + 1;
>      return instring;
>  }

I assume this depends on the database...
some use string_tdb_data() and some string_term_tdb_data()

I think we may need an option for this, so that it works with all
tdbs.

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
Url : http://lists.samba.org/archive/samba-technical/attachments/20080708/274f1713/signature.bin