[PATCH] Revised: OneFS build issues for Samba 3.2

[Zachary Loafman]

> -----Original Message-----
> From: Volker Lendecke [mailto:Volker.Lendecke at SerNet.DE]
> Sent: Friday, July 04, 2008 12:20 AM
> To: Zachary Loafman
> Cc: samba-technical at lists.samba.org
> Subject: Re: [PATCH] Revised: OneFS build issues for Samba 3.2
> 
> On Thu, Jul 03, 2008 at 11:46:40PM -0700, Zachary Loafman wrote:
> > The next two couple be merged or stays separate:
> > 0003 - Fixes various general warnings. The only potentially
> 
> Just curious about the logon_fn typedef: What warning did
> this generate?

The compiler decided that the variable 'domain' in the typedef shadowed
the 'domain' in the function parameter list. I personally think it's
incorrect (the variable name in the function prototype for a function
pointer should have no bearing on anything). My first fix was to remove
the variable names from the proto, but decided it was nicer to keep it
in there for documentation sake. 

We have a slightly antiquated compiler (gcc 3.4.4), so I wouldn't be
surprised if this didn't show up in more recent versions.

...Zach