[PATCH] [REPOST] mount.cifs: Allow passwords of length upto 127 bytes

[Suresh Jayaraman]

Neal A. Lucier wrote:
> Suresh Jayaraman wrote:
>>
>> The Windows versions above Windows 98 (Windows 2000, XP and above 
>> including Samba), support passwords up to 127 characters. NTLM passwords
>> are limited _only_ in GUI, because the dialog box limits it to 14
>> characters. So it makes sense for mount.cifs to allow passwords up to
>> 127 characters.
>>
> 
> This information is incorrect.  The GUI dialog box limits the password 
> length to 127 characters, not 14.  The 14 character limit is for lanman 

I was referring to the Windows NT4 GUI. Sorry, if I wasn't clear.

> passwords, and Windows will not generate the lanman hash if the password 
> length is over 14 characters.  The max password length for the actual 
> NTLM hash is 255, which windows supports everywhere except the GUI 
> dialog box, so mount.cifs should allow passwords up to 255.  As Steve 
> French even demonstrates using the Windows command line in this post in 
> response to you:

Correct. I think we can discuss and decide on whether the maximum 
password length should be limited to 127 (to make it consistent with 
GUI) or to 255. However, the current limit of 16 is too strict and has 
to be changed at any case, IMHO.


Thanks,

-- 
Suresh Jayaraman