[Q] enumprinterdrivers 2|3 is broken

Alexander Bokovoy ab at samba.org
Thu Jul 3 06:03:59 GMT 2008


2008/7/3 Jeremy Allison <jra at samba.org>:
>> This difference actually has a harm effect: Windows client thinks that
>> a driver is changed on the server and reloads it from the Samba server
>> on each opening of the printer properties. This is quite noticeable
>> for large drivers as network consumption increases.
>> We could normalize name in
>> rpc_parse/rpc_parse_spoolss.c:spoolss_io_q_enumprinterdrivers()
>> (reffering to 3-0-stable source) or could strip/normalize in
>> enumprinterdrivers_level2(). Not sure which way is better and safer.
>> This logical error exists in rpc code in 3-0 and upwards.
> Alexander, can you test this patch for me please ?
> Should fix all uses of \\[\\..]servername to be
> a canonical \\servername.
Sorry for slow responses, I'm on vacation with my family and only have
ten or so minutes per day to check email/look through the code. I see
you put the fix into v3-0-test, I'll ask a reporter to re-test.

/ Alexander Bokovoy

More information about the samba-technical mailing list