IRIX cc fixes for Samba 3.2.0

Jeremy Allison jra at
Tue Jul 1 22:41:21 GMT 2008

On Tue, Jul 01, 2008 at 09:37:04PM -0000, Jim Brown wrote:
> There are three source files that compare unsigned values with 0.
> The is one source file with an invalid format in a DEBUG message.
> Here are the patches for all four problems.
> 1. lib/replace/strptime.c: get_number and get_alt_number macros.
>    This is cosmetic since there is a matching upper limit check (this
> removes many compiler warnings).
> 2. lib/smbconf/smbconf_util.c: the decrementing loop variable is always
> non-negative.
>    This is an error.
> 3. libsmb/clientgen.c: the return code in 'len' is always non-negative.
>    This is an error.
> 4. smbd/oplock_irix.c: Invalid format: '5s' instead of '%s' in DEBUG level 5
> macro.
>    This is an error.

Thanks, I've fixed these except for (1), which is in code so
complex I'm not going to mess with it until I completely
understand it :-).

Also I think (2) exposed a more general bug in that the
index should be decremented, not incremented here.

Thanks for your sharp eyes !


More information about the samba-technical mailing list