Get Samba version or capability information from Windows

Corinna Vinschen corinna at
Thu Jan 24 11:47:18 GMT 2008

On Jan 24 10:04, Volker Lendecke wrote:
> On Wed, Jan 23, 2008 at 05:46:00PM +0100, Corinna Vinschen wrote:
> > Would a similar patch also be ok for the 3.0 branch?
> I'd be fine with it.


While testing I found that the commited patch has a flaw.  In the
original version I relied on the fact that the local static variable
"extended_info" in samba_extended_info_version() is initialized to 0.
That's an obviously incorrect assumption if the extended_info struct is
given as an argument pointer.  So, the first patch attached fixes the
chance that samba_subversion and samba_gitcommitdate might be
uninitialized in the 3-2-test branch and removes a left over comment.

The second patch backports the ExtendedInfo reply to a
SMB_FS_OBJECTID_INFORMATION query from the 3-2-test branch to the
3-0-test branch, including the fix from the first patch.

The object id itself gets not set and the 3.0 branch will
consequentially not set the FILE_SUPPORTS_OBJECT_IDS flag in a
SMB_FS_ATTRIBUTE_INFORMATION reply.  I tested to add that stuff
to 3.0 and it's no problem.  If you prefer that, I'll create a new
patch which also adds the object id.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: samba-extended-fix-3.2.diff
Type: text/x-patch
Size: 995 bytes
Desc: not available
Url :
-------------- next part --------------
A non-text attachment was scrubbed...
Name: samba-extended-3.0.diff
Type: text/x-patch
Size: 3403 bytes
Desc: not available
Url :

More information about the samba-technical mailing list