[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-test-1603-gc8def55

Jeremy Allison jra at samba.org
Tue Jan 22 19:22:40 GMT 2008


On Tue, Jan 22, 2008 at 02:13:28AM -0600, Volker Lendecke wrote:
> The branch, v3-2-test has been updated
>        via  c8def5564739c4c754001f84fcfb77f1093b96c3 (commit)
>       from  196e4ce8c5dd5aab518aaa7d170eb1fb5d66bcd1 (commit)
> 
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test
> 
> 
> - Log -----------------------------------------------------------------
> commit c8def5564739c4c754001f84fcfb77f1093b96c3
> Author: Volker Lendecke <vl at samba.org>
> Date:   Tue Jan 22 09:13:25 2008 +0100
> 
>     Fix a segfault
>     
>     Found by the IBM checker.
>     
>     Jeremy, you changed this from 'dirname == 0' which does not make sense at all
>     in the old code to '!dirname == 0' which from my point of view makes even less
>     sense, because the precedence of ! is according to Harbison/Steele higher than
>     the precedence of ==. Please check that the code now actually does what it's
>     supposed to do.

Wow - that change made no sense at all did it. Wonder what drugs I was
on when I did that one :-). Sorry. Thanks for the fix.

Jeremy.


More information about the samba-technical mailing list