Get Samba version or capability information from Windows

[Corinna Vinschen]

On Jan 21 16:25, Corinna Vinschen wrote:
> On Jan 21 16:23, Volker Lendecke wrote:
> > On Mon, Jan 21, 2008 at 04:07:59PM +0100, Corinna Vinschen wrote:
> > > > Hmmm. We got through some pain getting rid of this kind of
> > > > static, I'd much rather prefer this to be on the stack,
> > > > given to samba_extra_info_version() via a pointer.
> > > 
> > > Ok, no worries.  My first attempt was using this approach, but then I
> > > saw that the samba_version_string() function also uses a static local
> > > for the version string, so I changed my code to do the same.
> > 
> > In your patch I think you recomputed that struct each time
> > it was called.
> 
> No, my patch only did that once.

...and there's in theory no reason to do this every time an OBJECTID
request is made by a Windows client.  As the version string, the
extra_info structure is always the same.


Corinna