Get Samba version or capability information from Windows
Volker.Lendecke at SerNet.DE
Mon Jan 21 15:23:56 GMT 2008
On Mon, Jan 21, 2008 at 04:07:59PM +0100, Corinna Vinschen wrote:
> > Hmmm. We got through some pain getting rid of this kind of
> > static, I'd much rather prefer this to be on the stack,
> > given to samba_extra_info_version() via a pointer.
> Ok, no worries. My first attempt was using this approach, but then I
> saw that the samba_version_string() function also uses a static local
> for the version string, so I changed my code to do the same.
In your patch I think you recomputed that struct each time
it was called. This is different from the version.c one
which only ever creates that string once. The string in
version.c is not nice though, but it's a slightly different
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20080121/d6ff2b12/attachment.bin
More information about the samba-technical