round 1: ndr on top of trans2

Andrew Bartlett abartlet at
Mon Jan 21 00:14:56 GMT 2008

On Fri, 2008-01-18 at 13:03 +0100, Stefan (metze) Metzmacher wrote:
> Amin Azez schrieb:
> > It'll be a new day before I can test this, but taken that it works (or
> > can be made to) is their anything architecturally offensive in it?
> > Have I missed any useful use of params (which I ignore)?
> >  
> > smbcli_ndr_request_trans2_send() sends (or at least constructs right
> > now) a trans2 smbcli_request based on an NDR representation produced by
> > gen_ndr generated code, and packed directly onto the smbcli_request, to
> > save tallocs and memcpy.
> I think using ndr makes no sense here at all.

Why?  It sure beats hand-marshaling...

Andrew Bartlett
Andrew Bartlett
Authentication Developer, Samba Team 
Samba Developer, Red Hat Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url :

More information about the samba-technical mailing list