[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-test-1536-g6022873

[Jeremy Allison]

On Sat, Jan 19, 2008 at 04:50:50PM -0600, Volker Lendecke wrote:
> The branch, v3-2-test has been updated
>        via  6022873cc155bdbbd3fb620689715f07a24d6ed1 (commit)
>       from  d813bd9e02d9baf916eb96c478be89f0c435e07c (commit)
> 
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test
> 
> 
> - Log -----------------------------------------------------------------
> commit 6022873cc155bdbbd3fb620689715f07a24d6ed1
> Author: Volker Lendecke <vl at samba.org>
> Date:   Sat Jan 19 23:25:36 2008 +0100
> 
>     Add streams support
>     
>     This is the core of the streams support. The main change is that in
>     files_struct there is now a base_fsp pointer that holds the main file open
>     while a stream is open. This is necessary to get the rather strange delete
>     semantics right: You can't delete the main file while a stream is open without
>     FILE_SHARE_DELETE, and while a stream is open a successful unlink of the main
>     file leads to DELETE_PENDING for all further access on the main file or any
>     stream.

> diff --git a/source/smbd/filename.c b/source/smbd/filename.c
> @@ -206,6 +214,18 @@ NTSTATUS unix_convert(TALLOC_CTX *ctx,
>  		return NT_STATUS_NO_MEMORY;
>  	}
>  
> +	stream = strchr_m(name, ':');
> +
> +	if (stream != NULL) {
> +		char *tmp = talloc_strdup(ctx, stream);
> +		if (tmp == NULL) {
> +			TALLOC_FREE(name);
> +			return NT_STATUS_NO_MEMORY;
> +		}
> +		*stream = '\0';
> +		stream = tmp;
> +	}
> +

Wow - this is impressive work ! Only one worry. Doesn't
the above change to smbd/filename.c break unix_convert
for POSIX paths ?

Jeremy.