smbd SEGFAULTS in ldap code

[Martin Zielinski]

Volker Lendecke schrieb:
> On Tue, Jan 15, 2008 at 10:52:06AM +0100, Martin Zielinski wrote:
>> The smbd tries to mark the last entry in "libads/ldap.c ads_gen_add()" 
>> with 0, but this can be anywhere behind the objectClass attribute.
> 
> This code is, well, old...
> 
> Does the attached simple patch help? For me it compiles, but
> I did not test it. Your analysis looks 100% correct, and
> this might actually work around the deeper problem which is
> just ugly code.
> 
> Volker
Patch is ok.
It will cause a memory reallocation, no matter if it is needed or not, 
so it's not nice.

If you know for sure, that this problem can not occur in other cases 
(joining, updating the ADS membership etc. etc.), then it will do it.

Thanks,

Martin