please do not merge and modify patches in the same commit

James Peach jorgar at
Tue Jan 15 00:16:41 GMT 2008

On 14/01/2008, Gerald (Jerry) Carter <jerry at> wrote:
> Hash: SHA1
> Case in point.  I have no idea who "me" is in the commit.
> Please don't do this.

Sorry. I agree that this is poor style.

>  Either you are the author or not.
>  commit db74b99d0ef1a60894c838b4c9d0d454db6cf620
>  Author: Rishi Srivatsavai <rishisv at>
>  Date:   Mon Dec 17 22:09:09 2007 -0800
>     Add smbclient support for basic mDNS browsing.
>     Patch from Rishi Srivatsavai (bugzilla #4150), with tallocification
>     and minor syle changes by me.

mea cupla

James Peach | jorgar at

More information about the samba-technical mailing list