talloc pools -- if someone feels like it, please comment

Andrew Bartlett abartlet at samba.org
Wed Jan 9 23:16:35 GMT 2008

On Wed, 2008-01-09 at 18:45 +0100, Volker Lendecke wrote:
> Hi!
> Attached find a patch that potentially speeds up Samba 3
> considerably. I've talked about this to Jeremy, Tridge and
> Metze already, and I think I've addressed most concerns. In
> particular talloc_steal() now works as it does in current
> code, although it can certainly leave behind more memory
> (the whole pool) if used inappropriately.

My only concern is that it appears that the 'inappropriate' use is
something that has (for better or worse, and I know there have been
strong feelings about this in the past) been quite a useful programming
idiom in Samba4.

Otherwise, this looks like a really neat trick, even if it starts down
the process of running our own malloc...  I presume it would also make
valgrind memory tracking a little harder to figure out. 

Andrew Bartlett

Andrew Bartlett
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Red Hat Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20080110/cdd39d56/attachment.bin

More information about the samba-technical mailing list