[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-1054-gd6575ff

Michael Adam ma at sernet.de
Fri Jan 4 14:16:08 GMT 2008


Thanks Günther,

that is of course correct. There was the silent assumption
(that is generally right) that regdb_open or regdb_init had
been called before regdb_close...

While we're at it, I have the impression I should rethink
the design of the regdb_init/_open mechanism. :-)

Cheers - Michael

Günther Deschner wrote:
> The branch, v3-2-test has been updated
>        via  d6575ff5d240ec431b6e837494913dbd06e5a299 (commit)
>       from  aaea8f1ed744e9662f92a3840d86ad1aff943d18 (commit)
> 
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test
> 
> 
> - Log -----------------------------------------------------------------
> commit d6575ff5d240ec431b6e837494913dbd06e5a299
> Author: Günther Deschner <gd at samba.org>
> Date:   Fri Jan 4 12:57:49 2008 +0100
> 
>     Fix crash bug in regdb_close() when called with no ref count.
>     
>     Michael, please check.
>     
>     Guenther
> 
> -----------------------------------------------------------------------
> 
> Summary of changes:
>  source/registry/reg_db.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> 
> Changeset truncated at 500 lines:
> 
> diff --git a/source/registry/reg_db.c b/source/registry/reg_db.c
> index 25c6557..1979929 100644
> --- a/source/registry/reg_db.c
> +++ b/source/registry/reg_db.c
> @@ -329,6 +329,10 @@ WERROR regdb_open( void )
>  
>  int regdb_close( void )
>  {
> +	if (tdb_refcount == 0) {
> +		return 0;
> +	}
> +
>  	tdb_refcount--;
>  
>  	DEBUG(10,("regdb_close: decrementing refcount (%d)\n", tdb_refcount));
> 
> 
> -- 
> Samba Shared Repository

-- 

i.A. Michael Adam

-- 
Michael Adam <ma at sernet.de>
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.SerNet.DE, mailto: Info @ SerNet.DE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 206 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20080104/380bc431/attachment.bin


More information about the samba-technical mailing list