[SCM] Samba Shared Repository - branch v3-2-test updated -
Volker.Lendecke at SerNet.DE
Fri Feb 29 14:16:18 GMT 2008
On Fri, Feb 29, 2008 at 06:00:08AM -0800, Jeremy Allison wrote:
> In client/client.c this causes :
> client/client.c: In function ‘do_get’:
> client/client.c:1051: warning: passing argument 8 of ‘cli_pull’ from incompatible pointer type
> client/client.c:982: warning: unused variable ‘read_size’
> which means we're not using the io_bufsize setting.
> We need to talk about this so we can understand the
> semantics of this change.
You mean the
static int io_bufsize = 64512;
With this setting we would loose most of what that patch
does, that's why I'm hard-coding that 1024*1024 bufsize in
the call to cli_pull in do_get. If we had a default of 64k
read window then we would not gain anything from parallel
reads. With this change I anyhow doubt that the huge buffer
sizes gain more than just some very few percent, I would be
very surprised if it gains anything at all on gigabit
ethernet. 10gig ethernet might be different though.
io_bufsize here is very similar to the TCP window size, and
on fast networks you don't get very far with 64k.
We could pass io_bufsize to cli_pull, but then I would
really like to increase the default value of io_bufsize to
at least half a meg.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20080229/aa2697dc/attachment.bin
More information about the samba-technical