[SAMBA4][PATCH] Recursive registry key delete (from bz #5178)

[Andrew Kroeger]

Jelmer Vernooij wrote:
> Thanks! Overall, these changes look ok. Some minor comments:

I am attaching a new set of patches that address your comments.  The
patches are also reflected at git://git.id10ts.net/samba.git.

Please let me know if there are any additional changes that need to be made.

> Rather than ifdeffing out some tests, I would rather see the rpc-winreg
> test be converted to the new torture API and having the individual tests
> marked as known failing. AFAIK these tests pass against Windows, so it
> would be a shame to disable them against Windows as well.

Done.  I'm not sure if this is exactly what you were expecting.  It
ended up being more work than I thought to get the security descriptor
test code separated out in a somewhat clean fashion without duplicating
a bunch of code or passing a ton of extra variables around.

Once I got the code separated, I simply used a consistent naming
approach for the tests ("*-basic" and "*-security") to allow the
security descriptor tests to easily be marked knownfail.

> Please don't move functions within the file unless there's a reason for
> it. It makes it harder to review.

Per your earlier comment, I have left this in.

> The gotos in the recursive ldb delete function seem to make the code
> more rather than less complex and they each only save one line. Any
> chance you can remove at least one of the two labels?

These have been removed.

Thanks,
Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-registry-Implement-recursive-deletes-for-ldb-backed.patch
Type: text/x-patch
Size: 4922 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20080226/6de59c03/0001-registry-Implement-recursive-deletes-for-ldb-backed.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-registry-Implement-recursive-deletes-for-dir-backed.patch
Type: text/x-patch
Size: 2554 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20080226/6de59c03/0002-registry-Implement-recursive-deletes-for-dir-backed.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-registry-Implement-recursive-deletes-for-regf-backe.patch
Type: text/x-patch
Size: 2597 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20080226/6de59c03/0003-registry-Implement-recursive-deletes-for-regf-backe.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-registry-Add-an-explicit-test-for-recursive-deletio.patch
Type: text/x-patch
Size: 2499 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20080226/6de59c03/0004-registry-Add-an-explicit-test-for-recursive-deletio.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-torture-rpc-winreg-General-fixes-for-a-number-of-te.patch
Type: text/x-patch
Size: 2642 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20080226/6de59c03/0005-torture-rpc-winreg-General-fixes-for-a-number-of-te.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-torture-rpc-winreg-Modify-test-cases-to-work-with-r.patch
Type: text/x-patch
Size: 3207 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20080226/6de59c03/0006-torture-rpc-winreg-Modify-test-cases-to-work-with-r.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-torture-rpc-winreg-Split-out-the-security-descripto.patch
Type: text/x-patch
Size: 8513 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20080226/6de59c03/0007-torture-rpc-winreg-Split-out-the-security-descripto.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-samba4-knownfail-Only-the-security-rpc-winreg-t.patch
Type: text/x-patch
Size: 772 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20080226/6de59c03/0008-samba4-knownfail-Only-the-security-rpc-winreg-t.bin