[PATCH] Add variable to define if a share should be hidden.

David Collier-Brown davecb at sun.com
Tue Feb 26 14:51:35 GMT 2008


  A janitorial question: are not the variables the opposites
of each other, so browseable = no means the same as hidden = yes?

  If so, and if someone created a share called "foo$", then we
could set the variable by default, and report it in testparm
as whichever of browseable = no or hidden = yes makes sense.

  Otherwise we risk creating two disjoint variables with 
overlapping semantics, which will look bizzare to anyone
trying to figure out which to use... and they they'll get it
wrong!

--dave

Stefan (metze) Metzmacher wrote:
> Andreas Schneider schrieb:
> 
>>Stefan (metze) Metzmacher wrote:
>>
>>>Andreas Schneider schrieb:
>>>
>>>>If you create a share on a Windows machine called foo$ then this
>>>>share is
>>>>of the type STYPE_DISKTREE. So it is possible to administrate this
>>>>kind of
>>>>share. Tested on Windows NT and 2003.
>>>>
>>>>Start / Programs / Administrative Tools / Active Directory Users and
>>>>Computers
>>>>Shares / Select Share / Right Mouse Click / Manage
>>>>
>>>>In samba we assume that if a share with a $ at the end must be of the
>>>>type
>>>>STYPE_DISKTREE_HIDDEN. This is wrong, so we need a variable in the
>>>>config
>>>>to define if the share should be hidden or not.
>>>>
>>>>Attached are patches for 3.0 and 3.2 and a xml file for the
>>>>documentation.
>>>>
>>>
>>>Hi Andreas,
>>>
>>>isn't that what browseable = no is for? Instead of adding a new
>>>"hidden = yes" parameter.
>>
>>Then you have to set the STYPE_HIDDEN bits if browseable = No. IPC$ and
>>ADMIN$ are STYPE_DISTREE_HIDDEN, but are set to browseable = Yes.
>>
>>So you have to change them to 'browseable = No' to set STYPE_HIDDEN.
>>
>>I think its better introduce a new variable.
> 
> 
> I got it, just ignore me:-)
> 
> metze
> 

-- 
David Collier-Brown            | Always do right. This will gratify
Sun Microsystems, Toronto      | some people and astonish the rest
davecb at sun.com                 |                      -- Mark Twain
(905) 943-1983, cell: (647) 833-9377, home off: (416) 223-5943 
(800) 555-9786 x56583, bridge: (877) 385-4099 code: 506 9191#


More information about the samba-technical mailing list